This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
update the source for the snapcraft package #5781
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like this contributor signed our Contributor License Agreement. 👍 Many thanks, Parity Technologies CLA Bot |
|
Now that you moved the snapcraft.yaml to the snap directory, there's a duplicated one in the scripts directory. Should we remove that one? |
5chdn
added
A1-onice 🌨
|
Putting this on ice until the @paritytech/ci decides which script they use as discussed in #5496 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The source attribute of the snapcraft.yaml is relative to the directory where snapcraft is called.
When there's a snap directory in the root of the proyect, snapcraft should be called from the root, and thus we were going back one extra directory.