Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Clean up function naming in RPC error module #5995

Merged
merged 1 commit into from
Jul 6, 2017
Merged

Conversation

axelchalon
Copy link
Contributor

I'm glad to have found somewhere to start :P

Closes #3204 ; here are the changes to the function names:

errors::encryption_error => errors::encryption
errors::encoding_error => errors::encoding
errors::database_error => errors::database
errors::from_fetch_error => errors::fetch
errors::from_signing_error => errors::signing
errors::from_password_error => errors::password
errors::from_transaction_error => errors::transaction
errors::from_call_error => errors::call

Let me know if you have better ideas for some names or if there are other things to be done!

@parity-cla-bot
Copy link

It looks like @axelchalon hasn'signed our Contributor License Agreement, yet.

The purpose of a CLA is to ensure that the guardian of a project's outputs has the necessary ownership or grants of rights over all contributions to allow them to distribute under the chosen licence.
Wikipedia

You can read and sign our full Contributor License Agreement at the following URL: https://cla.parity.io

Once you've signed, plesae reply to this thread with [clabot:check] to prove it.

Many thanks,

Parity Technologies CLA Bot

@axelchalon
Copy link
Contributor Author

[clabot:check]

@parity-cla-bot
Copy link

It looks like @axelchalon signed our Contributor License Agreement. 👍

Many thanks,

Parity Technologies CLA Bot

@rphmeier rphmeier added A0-pleasereview 🤓 Pull request needs code review. M6-rpcapi 📣 RPC API. A4-awaitingci 🤖 Pull request is waiting for changes on the CI to complete tests before review/merge can begin. A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Jul 4, 2017
@debris
Copy link
Collaborator

debris commented Jul 4, 2017

lgtm

Copy link
Collaborator

@tomusdrw tomusdrw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@keorn keorn removed the A4-awaitingci 🤖 Pull request is waiting for changes on the CI to complete tests before review/merge can begin. label Jul 6, 2017
@debris debris merged commit a3a4a37 into master Jul 6, 2017
@debris debris deleted the rpc-errors-naming-3204 branch July 6, 2017 09:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A8-looksgood 🦄 Pull request is reviewed well. M6-rpcapi 📣 RPC API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants