Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Support comments in reserved peers file (#6004) #6012

Merged
merged 1 commit into from
Jul 10, 2017

Conversation

axelchalon
Copy link
Contributor

@axelchalon axelchalon commented Jul 6, 2017

Closes #6004

I made the parser ignore lines starting with # as suggested by Rob, and added a test for this.

You can test this by running parity with --reserved-peers ./peers.txt and have ./peers.txt be, for example:

# This is the validating node, owned by XXX corp
enode://6f8a80d14311c39f35f516fa664deaaaa13e85b2f7493f37f6144d86991ec012937307647bd3b9a82abe2974e1407241d54947bbb39763a4cac9f77166ad92a0@172.0.0.1:30303
# This is another validating node, owned by YYY corp
enode://6f8a80d14311c39f35f516fa664deaaaa13e85b2f7493f37f6144d86991ec012937307647bd3b9a82abe2974e1407241d54947bbb39763a4cac9f77166ad92a1@172.0.0.1:30303
# This is a non-validating node, owned by ZZZZ corp
enode://6f8a80d14311c39f35f516fa664deaaaa13e85b2f7493f37f6144d86991ec012937307647bd3b9a82abe2974e1407241d54947bbb39763a4cac9f77166ad92a2@172.0.0.1:30303

@axelchalon axelchalon added A0-pleasereview 🤓 Pull request needs code review. M4-core ⛓ Core client code / Rust. labels Jul 6, 2017
@parity-cla-bot
Copy link

It looks like this contributor signed our Contributor License Agreement. 👍

Many thanks,

Parity Technologies CLA Bot

@arkpar arkpar added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Jul 10, 2017
@gavofyork gavofyork merged commit 7599e39 into master Jul 10, 2017
@gavofyork gavofyork deleted the comments-reserved-peers-6004 branch July 10, 2017 11:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A8-looksgood 🦄 Pull request is reviewed well. M4-core ⛓ Core client code / Rust.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants