Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

JournalDB option 1 fix #613

Merged
merged 8 commits into from
Mar 7, 2016
Merged

JournalDB option 1 fix #613

merged 8 commits into from
Mar 7, 2016

Conversation

gavofyork
Copy link
Contributor

No description provided.

@gavofyork gavofyork added the A0-pleasereview 🤓 Pull request needs code review. label Mar 6, 2016
@gavofyork
Fix replay_keys
0980c71 
Counters should never have an entry with zero value.
@gavofyork gavofyork added the P0-dropeverything 🌋 Everyone should address the issue now. label Mar 7, 2016
@gavofyork gavofyork mentioned this pull request Mar 7, 2016
Closed
@arkpar arkpar added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Mar 7, 2016
@NikVolf
Copy link
Contributor

NikVolf commented Mar 7, 2016

test journaldb::tests::reopen_remove ... FAILED

this is still expected to fail?

gavofyork pushed a commit that referenced this pull request Mar 7, 2016
Merge pull request #613 from ethcore/jdb_option1
318e7e9 
JournalDB option 1 fix
@gavofyork gavofyork merged commit 318e7e9 into master Mar 7, 2016
@gavofyork gavofyork deleted the jdb_option1 branch March 7, 2016 08:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
A8-looksgood 🦄 Pull request is reviewed well. P0-dropeverything 🌋 Everyone should address the issue now.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gavofyork @NikVolf @arkpar