This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Fix connecting to wildcard addresses. #6167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacogr
reviewed
Jul 27, 2017
| * Resolves a wildcard address to `window.location.hostname`; | ||
| */ | ||
| _resolveHost (url) { | ||
| const parts = url ? url.split(':') : []; |
There was a problem hiding this comment.
Would have probably gone for
let [host, port] = url ? url.split(':') : [];
But tiny preferences thing, nothing else.
jacogr
approved these changes
Jul 27, 2017
jacogr
added
A8-looksgood 🦄
arkpar
pushed a commit
that referenced
this pull request
Jul 27, 2017
arkpar
added a commit
that referenced
this pull request
Jul 27, 2017
* Light client improvements (#6156) * no seal checking * import command and --no-seal-check for light client * fix eth_call * tweak registry dapps lookup * ignore failed requests to non-server peers * Fix connecting to wildcard addresses. (#6167) * Don't display an overlay in case the time sync check fails. (#6164) * Small improvements to time estimation. * Temporarily disable NTP time check by default.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6166