This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
JournalDB with in-memory overlay (option2) #634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| { | ||
| if canon_id == journal.id { | ||
| for h in &journal.insertions { | ||
| match journal_overlay.backing_overlay.raw(&h) { |
There was a problem hiding this comment.
& is probably not needed here, cause h is already a reference.
debris
added
A8-looksgood 🦄
|
LGTM, but it probably needs additional review by @gavofyork |
gavofyork
added
the
A1-onice 🌨
|
will reconsider option2 tomorrow after option1 has tested through the night. would like to have the |
gavofyork
added
A7-looksgoodcantmerge 🙄
|
needs a merge |
gavofyork
added
A8-looksgood 🦄
| } | ||
| overlay_deletions.append(&mut journal.insertions); | ||
| } | ||
| index +=1; |
gavofyork
added
A1-onice 🌨
|
waiting on additional tests |
gavofyork
added a commit
that referenced
this pull request
Mar 12, 2016
JournalDB with in-memory overlay (option2)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#630
See code comments for description