This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Rename network_id to chain_id where applicable. #6345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomusdrw
added
A0-pleasereview 🤓
keorn
approved these changes
Aug 21, 2017
rphmeier
added
A8-looksgood 🦄
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #6330
To avoid confusion with
network_idI renamed all variables and methods tochain_id(that's the actuall name in the spec file and it makes more sense, since ETC and ETH share the same network id but have different chain ids).That's a breaking change in the RPC API (transactions serialization).
@keorn there are some changes in the engines - it seems that we used
network_idfor signing instead ofchain_id(seeverify_transaction_basic) - was that intentional? (chain_iddefaults tonetwork_idif it's not specified and eip155 is enabled)