This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Fixed sync handling large forks #647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -843,8 +843,8 @@ impl ChainSync { | |||
| self.downloading_bodies.remove(&n); | |||
| self.downloading_headers.remove(&n); | |||
| } | |||
| self.headers.remove_tail(&start); | |||
| self.bodies.remove_tail(&start); | |||
| self.headers.remove_from(&start); | |||
There was a problem hiding this comment.
All following blocks/headers must be removed since it is possible that on a forked chain a block body (same transaction/uncles) will belong to a block with a different number or hash, which will cause a block body-to header mismatch.
gavofyork
added
A8-looksgood 🦄
gavofyork
pushed a commit
that referenced
this pull request
Mar 9, 2016
Fixed sync handling large forks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a panic when syncing Morden chain, which is currently forked. Most peers are on the invalid chain