This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Transaction queue exposed via JSON rpc. #652
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 9 commits
March 1, 2016 23:06
|
also |
|
@debris I will make a separate PR with that, seems a bit complicated (tracking pending between polling requests) |
|
Here it is #661 |
debris
added
A8-looksgood 🦄
| @@ -255,6 +257,7 @@ impl ChainSync { | |||
| blocks_total: match self.highest_block { Some(x) if x > self.starting_block => x - self.starting_block, _ => 0 }, | |||
| num_peers: self.peers.len(), | |||
| num_active_peers: self.peers.values().filter(|p| p.asking != PeerAsking::Nothing).count(), | |||
| transaction_queue_pending: self.transaction_queue.lock().unwrap().status().pending, | |||
There was a problem hiding this comment.
Comment not related with this pr.
I'm just curious, if it is possible to provide transaction_queue interior threadsafety instead of external? Or at least replace Mutex with RwLock?
There was a problem hiding this comment.
- I can try that, but my gut feeling is that we will have to lock every field anyhow.
- It's not possible to replace
MutexwithRwLockbecauseSignedTransactionis notSync(because it hasCellinternally). So I would have to copy all fields fromSignedTransationtoVerifiedTransactionand then back (when returning) or protectSignedTransationwithMutex.
Will try to tinker with it a little bit later today.
debris
added a commit
that referenced
this pull request
Mar 11, 2016
Transaction queue exposed via JSON rpc.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.