Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

default parity.service file allows unclean exit #6592

Closed
antonioshadji opened this issue Sep 26, 2017 · 1 comment
Closed

default parity.service file allows unclean exit #6592

antonioshadji opened this issue Sep 26, 2017 · 1 comment
Labels
F3-annoyance 💩 The client behaves within expectations, however this “expected behaviour” itself is at issue. M1-ci 🙉 Continuous integration. P7-nicetohave 🐕 Issue is worth doing eventually.
Milestone

Comments

@antonioshadji
Copy link
Contributor

Using the default parity.service file on linux I get the follow log messages after
sudo systemctl stop parity.service

Sep 25 17:45:09 hadji systemd[1]: Stopping Parity Daemon...
Sep 25 17:45:09 hadji parity[14783]: 2017-09-25 17:45:09 main INFO parity::run Finishing work, please wait...
Sep 25 17:45:14 hadji parity[14783]: 2017-09-25 17:45:14 IO Worker #0 INFO import Syncing #4311484 e9fb…e28d 0 blk/s
Sep 25 17:45:14 hadji parity[14783]: 2017-09-25 17:45:14 WARN jsonrpc_ws_server::session Error while sending response: WS E
Sep 25 17:45:14 hadji parity[14783]: pure virtual method called
Sep 25 17:45:14 hadji parity[14783]: terminate called without an active exception
Sep 25 17:45:14 hadji systemd[1]: parity.service: Main process exited, code=killed, status=6/ABRT
Sep 25 17:45:14 hadji systemd[1]: Stopped Parity Daemon.
Sep 25 17:45:14 hadji systemd[1]: parity.service: Unit entered failed state.
Sep 25 17:45:14 hadji systemd[1]: parity.service: Failed with result 'signal'.

To improve , the main change is that I added
KillSignal=SIGHUP
in the [Service] section.

Here is a link to my current parity.service

Now running sudo systemctl stop parity.service I see the following when I check status.
● parity.service - Parity Daemon
Loaded: loaded (/etc/systemd/system/parity.service; enabled; vendor preset: enabled)
Active: inactive (dead) since Mon 2017-09-25 19:29:25 EDT; 6s ago
Main PID: 19607 (code=killed, signal=HUP)
...
Sep 25 19:29:25 hadji systemd[1]: Stopping Parity Daemon...
Sep 25 19:29:25 hadji systemd[1]: Stopped Parity Daemon.

On restart, the jsonrpc.ipc file had not been removed but it was handled cleanly.

Should I submit this as a pull request instead? I wanted to share this information. I don't have a current issue.

I'm running:
version Parity/v1.7.0-beta-5f2cabd-20170727/x86_64-linux-gnu/rustc1.18.0
on 4.10.0-33-generic #37~16.04.1-Ubuntu SMP Fri Aug 11 14:07:24 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
installed via installer

@5chdn 5chdn added F3-annoyance 💩 The client behaves within expectations, however this “expected behaviour” itself is at issue. M1-ci 🙉 Continuous integration. P7-nicetohave 🐕 Issue is worth doing eventually. labels Sep 26, 2017
@5chdn
Copy link
Contributor

5chdn commented Sep 26, 2017

Feel free to submit a PR, https://github.com/paritytech/parity/blob/master/scripts/parity.service :)

antonioshadji added a commit to antonioshadji/parity that referenced this issue Sep 26, 2017
Previous version put $BASE directory in root directory.
This version clearly explains how to run as root or as specific user.

Additional configuration:

* send SIGHUP for clean exit,

* restart on fail.

Tested on Ubuntu 16.04.3 LTS with 4.10.0-33-generic x86_64 kernel
@5chdn 5chdn added this to the 1.9 milestone Oct 5, 2017
arkpar pushed a commit that referenced this issue Oct 9, 2017
Previous version put $BASE directory in root directory.
This version clearly explains how to run as root or as specific user.

Additional configuration:

* send SIGHUP for clean exit,

* restart on fail.

Tested on Ubuntu 16.04.3 LTS with 4.10.0-33-generic x86_64 kernel
arkpar added a commit that referenced this issue Oct 9, 2017
* Fix wallet view (#6597)

* Add safe fail for empty logs

* Filter transactions

* Add more logging

* Fix Wallet Creation and wallet tx list

* Remove logs

* Prevent selecting twice same wallet owner

* Fix tests

* Remove unused props

* Remove unused props

* Disallow pasting recovery phrases on first run (#6602)

* Fix disallowing paste of recovery phrase on first run, ref #6581

* Allow the leader of CATS pasting recovery phrases.

* Updated systemd files for linux (#6592)

Previous version put $BASE directory in root directory.
This version clearly explains how to run as root or as specific user.

Additional configuration:

* send SIGHUP for clean exit,

* restart on fail.

Tested on Ubuntu 16.04.3 LTS with 4.10.0-33-generic x86_64 kernel

* Don't expose port 80 for parity anymore (#6633)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
F3-annoyance 💩 The client behaves within expectations, however this “expected behaviour” itself is at issue. M1-ci 🙉 Continuous integration. P7-nicetohave 🐕 Issue is worth doing eventually.
Projects
None yet
Development

No branches or pull requests

2 participants