This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Balance queries implemented in WASM runtime #6639
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lexfrl
added
A0-pleasereview 🤓
NikVolf
added
A8-looksgood 🦄
NikVolf
changed the title
rphmeier
reviewed
Oct 4, 2017
| let address = self.pop_address(&mut context)?; | ||
| let balance = self.ext.balance(&address).map_err(|_| UserTrap::BalanceQueryError)?; | ||
| let value: H256 = balance.into(); | ||
| self.memory.set(return_ptr, &*value)?; |
There was a problem hiding this comment.
does there need to be a check that the return pointer is actually valid i.e. in allocated memory or on the stack?
There was a problem hiding this comment.
how do you imagine such check?
There was a problem hiding this comment.
i'm not sure, just not familiar with the intricacies of WASM. to me it looks like it just writes into whatever pointer it's given. obviously if the pointer is invalid then it should lead to an error in the WASM runtime, but it shouldn't cause a panic in self.memory.set. Are we sure it doesn't?
There was a problem hiding this comment.
Yes - it doesn't panic - that's why memory.set returns Result<>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.