This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Disable preparing work package if miners don't ask for it. #771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomusdrw
added
A0-pleasereview 🤓
added 2 commits
March 18, 2016 19:36
Conflicts: ethcore/src/client/test_client.rs miner/src/miner.rs
tomusdrw
added
A0-pleasereview 🤓
|
needs resolving. |
|
also, would be good to include a bit of text here to describe the changes (in particular what state is added). |
Conflicts: miner/src/miner.rs
| let current_no = chain.chain_info().best_block_number; | ||
| let last_request = self.sealing_block_last_request.lock().unwrap(); | ||
|
|
||
| current_no - *last_request > SEALING_TIMEOUT_IN_BLOCKS |
There was a problem hiding this comment.
current_no can theoretically go down over time (e.g. a shorter fork with higher total difficulty)
gavofyork
added
A8-looksgood 🦄
|
looks good otherwise. |
tomusdrw
added
A0-pleasereview 🤓
gavofyork
added a commit
that referenced
this pull request
Mar 20, 2016
Disable preparing work package if miners don't ask for it.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we start preparing new block for sealing (after chain head changes) only if miner will ask for work package (i.e.
sealing_blockmethod is called). After that we will be preparing new blocks indefinitely even though no one is expecting us to do so.This PR introduces "block timeout". After
SEALING_TIMEOUT_IN_BLOCKS(constant) blocks without being asked forsealing_blockwe stop producing new blocks (sealing_enabledis flipped)