This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
SecretStore: ability to identify requester via Public/Address #7886
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In client sessions via HTTP requester (the one who queries/creates the server/document key) is always 'identified' by passing signature of server key id as the parameter.
While working with service contract, we can determine requester' address from
msg.sender
and it seems counter-productive to ask for another identification data (another security-related reason: everyone could intercept/read the signature from transaction and use it in HTTP API if available). So in service contract we will usemsg.sender
where possible and ask for full sender' public when required. In details:msg.sender
is required to remember in SS db and then authorize the same sender to store linked document keymsg.sender
is requiredmsg.sender
(to encrypt returned data). The contract will be responsible to check thataddress(public) = msg.sender