Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

SecretStore: store key author address in db #7887

Merged
merged 5 commits into from
Mar 20, 2018
Merged

Conversation

svyatonik
Copy link
Collaborator

on top of #7886
this PR is only for commit c7cae5c

Since we only know msg.sender when server key generation session is started via service contract => store address instead of full public in key entry.

@svyatonik svyatonik added A0-pleasereview 🤓 Pull request needs code review. M4-core ⛓ Core client code / Rust. labels Feb 14, 2018
@5chdn 5chdn added this to the 1.10 milestone Feb 14, 2018
@5chdn 5chdn modified the milestones: 1.10, 1.11 Mar 1, 2018
@5chdn 5chdn modified the milestones: 1.11, 1.12 Mar 1, 2018
@folsen
Copy link
Contributor

folsen commented Mar 13, 2018

Isn't there any case where we might want the public key instead of just an address? Or is any identifier in this case just as good as any other? I'm just thinking we're potentially throwing data away if it's not used via service contract, and so if it would be better to have a more generic structure that allows an address or a public key.

@svyatonik
Copy link
Collaborator Author

I can only imagine one potential case - we need to encrypt something with author' public - but the only thing SS hold are keys and author is not guaranteed to have a read access to its keys => author became requester when querying for keys/signatures => public is not required.

In all other cases, I guess, it is not required at all. Moreover, author always was a 'technical field' && it is only used to tie two requests together (second request can only be produced by the 'author' of the first one). Hope some day we'll get rid of this field at all (just after someone/me will find a way to securely generate document key in Secret Store, without requiring third party (author)).

@debris debris added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Mar 20, 2018
@debris debris merged commit a91e562 into master Mar 20, 2018
@debris debris deleted the secretstore_address_in_db branch March 20, 2018 02:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A8-looksgood 🦄 Pull request is reviewed well. M4-core ⛓ Core client code / Rust. P5-sometimesoon 🌲 Issue is worth doing soon.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants