Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Remove all redux dependencies from the signers #8024

Merged
merged 1 commit into from
Mar 1, 2018
Merged

Conversation

amaury1093
Copy link
Contributor

See parity-js/shell#9. Updating refs here to latest shell.

@amaury1093 amaury1093 added A3-inprogress ⏳ Pull request is in progress. No review needed at this stage. M7-ui labels Mar 1, 2018
@jacogr
Copy link
Contributor

jacogr commented Mar 1, 2018

Checked specific references against repos, up to date.

EDIT: Fixes the following -

  • Potential double-sends when machine is unresponsive (reported)
  • Signer issues with Ledger not working (due to serde-serialise changes)

@5chdn 5chdn added this to the 1.11 milestone Mar 1, 2018
@amaury1093 amaury1093 added A0-pleasereview 🤓 Pull request needs code review. and removed A3-inprogress ⏳ Pull request is in progress. No review needed at this stage. labels Mar 1, 2018
@jacogr jacogr added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Mar 1, 2018
Copy link
Contributor

@jacogr jacogr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, also tested with built version.

@5chdn 5chdn merged commit ea3083b into master Mar 1, 2018
@5chdn 5chdn deleted the am-new-signer branch March 1, 2018 12:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A8-looksgood 🦄 Pull request is reviewed well.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants