Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

refactored loading of execution tests #803

Merged
merged 3 commits into from
Mar 25, 2016
Merged

refactored loading of execution tests #803

merged 3 commits into from
Mar 25, 2016

Conversation

debris
Copy link
Collaborator

@debris debris commented Mar 24, 2016

  • moved loading of executive tests to json module.

@debris debris added the A0-pleasereview 🤓 Pull request needs code review. label Mar 24, 2016
tomusdrw
tomusdrw reviewed Mar 24, 2016
View reviewed changes
json/src/maybe.rs

/// Deserializer of empty string values into optionals.
#[derive(Debug, PartialEq)]
pub enum MaybeEmpty<T> {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not std::option::Option?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I need to parse empty string "" as None.

@debris debris changed the title refactored loading of execution tests, potential release blocker refactored loading of execution tests Mar 24, 2016
@tomusdrw tomusdrw added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Mar 25, 2016
@gavofyork gavofyork merged commit 100e6fa into master Mar 25, 2016
@gavofyork gavofyork deleted the executive_tests branch March 25, 2016 10:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
A8-looksgood 🦄 Pull request is reviewed well.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@debris @tomusdrw @gavofyork