Fix Cargo.lock not parsable #8102

tomaka · 2018-03-13T14:00:55Z

master doesn't build for me because Cargo.lock isn't parsable.

parity-cla-bot · 2018-03-13T14:00:58Z

It looks like @tomaka signed our Contributor License Agreement. 👍

Many thanks,

Parity Technologies CLA Bot

tomaka · 2018-03-13T14:05:40Z

[pierre@pierre-thinkpad parity]$ git fetch upstream
[pierre@pierre-thinkpad parity]$ git checkout upstream/master
HEAD is now at 102bc7809... Additional data in EVMTestClient (#7964)
[pierre@pierre-thinkpad parity]$ cargo b --verbose
error: failed to parse lock file at: /home/pierre/Projets/parity/Cargo.lock

Caused by:
  package `ethabi-derive 5.0.5 (registry+https://github.com/rust-lang/crates.io-index)` is specified as a dependency, but is missing from the package list

niklasad1

LGTM!

Fix Cargo.lock not parsable

b3e48cc

tomaka added the A0-pleasereview 🤓 Pull request needs code review. label Mar 13, 2018

niklasad1 approved these changes Mar 13, 2018

View reviewed changes

debris merged commit 7e948a0 into openethereum:master Mar 13, 2018

debris added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Mar 13, 2018

tomaka deleted the fix-build branch March 13, 2018 14:58

5chdn added this to the 1.11 milestone Mar 20, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix Cargo.lock not parsable #8102

Fix Cargo.lock not parsable #8102

tomaka commented Mar 13, 2018

parity-cla-bot commented Mar 13, 2018

tomaka commented Mar 13, 2018

niklasad1 left a comment

Fix Cargo.lock not parsable #8102

Fix Cargo.lock not parsable #8102

Conversation

tomaka commented Mar 13, 2018

parity-cla-bot commented Mar 13, 2018

tomaka commented Mar 13, 2018

niklasad1 left a comment

Choose a reason for hiding this comment