This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
secret_store: use ecies::encrypt/ecies::decrypt.
#8125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like @twittner signed our Contributor License Agreement. 👍 Many thanks, Parity Technologies CLA Bot |
svyatonik
reviewed
Mar 15, 2018
| @@ -241,15 +241,15 @@ pub fn deserialize_message(header: &MessageHeader, payload: Vec<u8>) -> Result<M | |||
| pub fn encrypt_message(key: &KeyPair, message: SerializedMessage) -> Result<SerializedMessage, Error> { | |||
| let mut header: Vec<_> = message.into(); | |||
| let payload = header.split_off(MESSAGE_HEADER_SIZE); | |||
| let encrypted_payload = encrypt_single_message(key.public(), &payload)?; | |||
There was a problem hiding this comment.
I don't mind using the &[], but there are already a couple of places in SS where ðcrypto::DEFAULT_MAC is passed instead. So maybe better to use the same value everywhere. But it is up to you.
svyatonik
approved these changes
Mar 15, 2018
svyatonik
added
A8-looksgood 🦄
General-Beck
added a commit
that referenced
this pull request
Mar 19, 2018
This reverts commit fed4864.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.