This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
jsonrpc-apis, ws-apis and ipc-apis update #8234
Merged
+3
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like @Tbaut signed our Contributor License Agreement. 👍 Many thanks, Parity Technologies CLA Bot |
tomusdrw
suggested changes
Mar 27, 2018
parity/cli/mod.rs
Outdated
| @@ -452,7 +452,7 @@ usage! { | |||
|
|
|||
| ARG arg_jsonrpc_apis: (String) = "web3,eth,pubsub,net,parity,parity_pubsub,traces,rpc,shh,shh_pubsub", or |c: &Config| c.rpc.as_ref()?.apis.as_ref().map(|vec| vec.join(",")), | |||
| "--jsonrpc-apis=[APIS]", | |||
| "Specify the APIs available through the JSONRPC interface. APIS is a comma-delimited list of API name. Possible name are all, safe, web3, eth, net, personal, parity, parity_set, traces, rpc, parity_accounts, pubsub, parity_pubsub, shh, shh_pubsub, signer, secretstore. You can also disable a specific API by putting '-' in the front: all,-personal.", | |||
| "Specify the APIs available through the JSONRPC interface. APIS is a comma-delimited list of API name. Possible names are: all, safe, web3, net, eth, pubsub, personal, signer, parity, parity_pubsub, parity_accounts, parity_set, traces, rpc, secretstore, shh, shh_pubsub. You can also disable a specific API by putting '-' in the front, example: all,-personal. safe contains following apis: traces, parity_pubsub", | |||
There was a problem hiding this comment.
Actually safe contains all APIs from public list:
https://github.com/paritytech/parity/blob/2e09db185f4cd443a4753c79458ce1105f60fcea/parity/rpc_apis.rs#L623-L632
plus traces and ParityPubSub.
|
Thanks @tomusdrw for spotting this :) |
tomusdrw
approved these changes
Mar 27, 2018
Tbaut
added
A2-insubstantial 👶
niklasad1
reviewed
Mar 27, 2018
parity/cli/mod.rs
Outdated
| @@ -452,7 +452,7 @@ usage! { | |||
|
|
|||
| ARG arg_jsonrpc_apis: (String) = "web3,eth,pubsub,net,parity,parity_pubsub,traces,rpc,shh,shh_pubsub", or |c: &Config| c.rpc.as_ref()?.apis.as_ref().map(|vec| vec.join(",")), | |||
| "--jsonrpc-apis=[APIS]", | |||
| "Specify the APIs available through the JSONRPC interface. APIS is a comma-delimited list of API name. Possible name are all, safe, web3, eth, net, personal, parity, parity_set, traces, rpc, parity_accounts, pubsub, parity_pubsub, shh, shh_pubsub, signer, secretstore. You can also disable a specific API by putting '-' in the front: all,-personal.", | |||
| "Specify the APIs available through the JSONRPC interface. APIS is a comma-delimited list of API name. Possible names are: all, safe, web3, net, eth, pubsub, personal, signer, parity, parity_pubsub, parity_accounts, parity_set, traces, rpc, secretstore, shh, shh_pubsub. You can also disable a specific API by putting '-' in the front, example: all,-personal. safe contains following apis: web3, net, eth, pubsub, parity, parity_pubsub, traces, rpc, shh, shh_pubsub", | |||
There was a problem hiding this comment.
Specify the APIs available through the JSONRPC interface which is a comma-delimited list of API names.
There was a problem hiding this comment.
If you agree change at the other places as well otherwise ignore it :)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.