Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Upgrader remove raw unwrap and bump semver #8251

Merged
merged 3 commits into from
Apr 4, 2018
Merged

Upgrader remove raw unwrap and bump semver #8251

merged 3 commits into from
Apr 4, 2018

Conversation

niklasad1
Copy link
Collaborator

If this is ok then we need to bump rustc_version crate to 0.2.2 it depends on semver 0.9.0 instead of 0.6.0

│           │   [build-dependencies]
│           │   └── rustc_version v0.2.1
│           │       [dependencies]
│           │       └── semver v0.6.0

@parity-cla-bot
Copy link

It looks like @niklasad1 signed our Contributor License Agreement. 👍

Many thanks,

Parity Technologies CLA Bot

@5chdn 5chdn added A0-pleasereview 🤓 Pull request needs code review. M4-core ⛓ Core client code / Rust. labels Mar 29, 2018
@5chdn 5chdn added this to the 1.11 milestone Mar 29, 2018
andresilva
andresilva reviewed Apr 2, 2018
View reviewed changes
Copy link
Contributor

@andresilva andresilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Can you bump the rustc_version dependency?

parity/upgrade.rs Outdated
@@ -32,6 +32,13 @@ pub enum Error {
CannotCreateConfigPath,
CannotWriteVersionFile,
CannotUpdateVersionFile,
Semver(SemVerError),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SemVer?

@niklasad1 niklasad1 force-pushed the upgrader/eliminate-unwrap-and-bump-semver branch from 0d9528b to ac0a5b5 Compare April 2, 2018 13:06
@debris debris added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Apr 4, 2018
@debris
Copy link
Collaborator

debris commented Apr 4, 2018 •
edited
Loading

needs merge with master ;)

@niklasad1 niklasad1 force-pushed the upgrader/eliminate-unwrap-and-bump-semver branch from 76d38da to cf971ec Compare April 4, 2018 09:21
@5chdn 5chdn merged commit ef80698 into openethereum:master Apr 4, 2018
@5chdn 5chdn added the M5-dependencies 🖇 Dependencies. label Apr 5, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@andresilva andresilva andresilva left review comments

@debris debris debris approved these changes

Assignees
No one assigned
Labels
A8-looksgood 🦄 Pull request is reviewed well. M4-core ⛓ Core client code / Rust. M5-dependencies 🖇 Dependencies.
Projects
None yet
Milestone
1.11 Prosperity
Development

Successfully merging this pull request may close these issues.
5 participants
@niklasad1 @parity-cla-bot @debris @andresilva @5chdn