This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Allow customization of max WS connections. #8257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomusdrw
added
A0-pleasereview 🤓
niklasad1
reviewed
Mar 29, 2018
parity/cli/mod.rs
Outdated
| "--ws-max-connections=[CONN]", | ||
| "Maximal number of allowed concurrent WS connections.", | ||
|
|
||
|
|
||
| ["API and console options – IPC"] |
There was a problem hiding this comment.
Remove extra empty line?
niklasad1
reviewed
Mar 29, 2018
|
Also I think you need to update the tests for the CI to pass! |
niklasad1
approved these changes
Mar 29, 2018
niklasad1
added
A8-looksgood 🦄
|
Wait a second - did this only allow for settings max WS connections but didn't address the default HTTP connection limit of 250? We don't use WS, only HTTP and have a major need to allow for way more than 250 connections. Major services like mysql often can run right up to the handle limit of 16k or whatever the default is on the OS. |
I guess it's pretty clear from the title. Please create a new issue/PR. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8117