Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

rpc, eth_filter: return error if the filter id does not exist #8341

Merged
merged 1 commit into from
Apr 10, 2018
Merged

rpc, eth_filter: return error if the filter id does not exist #8341

merged 1 commit into from
Apr 10, 2018

Conversation

sorpaas
Copy link
Collaborator

@sorpaas sorpaas commented Apr 9, 2018

Fixes #6706

When the requested filter id does not exist, return an error instead of silently fail.

@sorpaas sorpaas added A0-pleasereview 🤓 Pull request needs code review. M6-rpcapi 📣 RPC API. labels Apr 9, 2018
@sorpaas sorpaas added this to the 1.11 milestone Apr 9, 2018
debris
debris approved these changes Apr 10, 2018
View reviewed changes
Copy link
Collaborator

@debris debris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

neat!

@debris debris merged commit d1487b3 into openethereum:master Apr 10, 2018
@debris debris added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Apr 10, 2018
@debris debris mentioned this pull request Apr 17, 2018
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@debris debris debris approved these changes

Assignees
No one assigned
Labels
A8-looksgood 🦄 Pull request is reviewed well. M6-rpcapi 📣 RPC API.
Projects
None yet
Milestone
1.11 Prosperity
Development

Successfully merging this pull request may close these issues.
2 participants
@sorpaas @debris