Caching for computing seed hashes (#541) #841
Conversation
gavofyork
added
A0-pleasereview 🤓
|
lgtm - one more review pls. |
| @@ -85,6 +86,7 @@ pub type H256 = [u8; 32]; | |||
| pub struct Light { | |||
| block_number: u64, | |||
| cache: Vec<Node>, | |||
| eth_compute: Mutex<EthCompute>, | |||
There was a problem hiding this comment.
You don't need a mutex here. Light structures are already accessed in a synchronized way in EthashManager
There was a problem hiding this comment.
This needs to be a threadsafe, due to it's use by Ethash - because Engine has a Sync constraint.
There was a problem hiding this comment.
This structure is not a member of Engine. It is managed by EthashManager only. Adding Mutex to eth.rs is fine because Sync is required there indeed. Light does not to be Sync though
There was a problem hiding this comment.
Right, the light struct in fact can be used out of the lock. Sorry for the confusion.
arkpar
added
A4-gotissues 💥
|
|
||
| #[inline] | ||
| pub fn resume_compute_seedhash(mut hash: H256, start_epoch: u64, end_epoch: u64) -> H256 { | ||
| println!("COMPUTE {:?} {:?}", start_epoch, end_epoch); |
There was a problem hiding this comment.
I probably should remove this too. It was just for debugging.
Code review changes
gavofyork
added
A8-looksgood 🦄
No description provided.