Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

passing key path to all invocations #891

Merged
merged 2 commits into from
Apr 6, 2016
Merged

passing key path to all invocations #891

merged 2 commits into from
Apr 6, 2016

Conversation

NikVolf
Copy link
Contributor

@NikVolf NikVolf commented Apr 6, 2016

#882

bug existed because no code in parity.rs actually passed args.flag_keys_path to any constructor of SecretStore/AccountService

was fixed by adding this pass

@NikVolf NikVolf added A0-pleasereview 🤓 Pull request needs code review. A3-inprogress ⏳ Pull request is in progress. No review needed at this stage. and removed A0-pleasereview 🤓 Pull request needs code review. labels Apr 6, 2016
@NikVolf NikVolf added A0-pleasereview 🤓 Pull request needs code review. and removed A3-inprogress ⏳ Pull request is in progress. No review needed at this stage. labels Apr 6, 2016
@arkpar arkpar added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Apr 6, 2016
@debris debris merged commit a8eb34d into master Apr 6, 2016
@debris debris deleted the issue-882 branch April 6, 2016 16:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
A8-looksgood 🦄 Pull request is reviewed well.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@NikVolf @debris @arkpar