From 7768b77d53eb9a6585faace16fac27091895bc56 Mon Sep 17 00:00:00 2001
From: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Date: Wed, 30 Aug 2023 11:32:34 +0200
Subject: [PATCH] Remove old UI test (#1289)

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Co-authored-by: Liam Aharon <liam.aharon@hotmail.com>
---
 .gitlab/pipeline/test.yml                     |  9 +++----
 .../test/tests/construct_runtime_ui.rs        |  3 +++
 .../genesis_default_not_satisfied.rs          | 26 -------------------
 .../genesis_default_not_satisfied.stderr      | 16 ------------
 4 files changed, 7 insertions(+), 47 deletions(-)
 delete mode 100644 substrate/frame/support/test/tests/pallet_ui/genesis_default_not_satisfied.rs
 delete mode 100644 substrate/frame/support/test/tests/pallet_ui/genesis_default_not_satisfied.stderr

diff --git a/.gitlab/pipeline/test.yml b/.gitlab/pipeline/test.yml
index 9dc14d7f1639..c81750d49f92 100644
--- a/.gitlab/pipeline/test.yml
+++ b/.gitlab/pipeline/test.yml
@@ -212,7 +212,7 @@ test-deterministic-wasm:
     - .common-refs
   # DAG
   needs:
-    - job: test-frame-support
+    - job: test-frame-ui
       artifacts: false
   script:
     - .gitlab/test_deterministic_wasm.sh
@@ -295,7 +295,7 @@ node-bench-regression-guard:
 
 # if this fails (especially after rust version upgrade) run
 # ./substrate/.maintain/update-rust-stable.sh <rust_version>
-test-frame-support:
+test-frame-ui:
   stage: test
   extends:
     - .docker-env
@@ -314,9 +314,8 @@ test-frame-support:
     # Ensure we run the UI tests.
     RUN_UI_TESTS: 1
   script:
-    - time cargo test --locked -p frame-support-test --features=frame-feature-testing,no-metadata-docs,try-runtime,experimental --manifest-path ./substrate/frame/support/test/Cargo.toml
-    - time cargo test --locked -p frame-support-test --features=frame-feature-testing,frame-feature-testing-2,no-metadata-docs,try-runtime,experimental --manifest-path ./substrate/frame/support/test/Cargo.toml
-    - SUBSTRATE_TEST_TIMEOUT=1 time cargo test -p substrate-test-utils --release --locked -- --ignored timeout
+    - time cargo test --locked -q --profile testnet -p frame-support-test --features=frame-feature-testing,no-metadata-docs,try-runtime,experimental
+    - time cargo test --locked -q --profile testnet -p frame-support-test --features=frame-feature-testing,frame-feature-testing-2,no-metadata-docs,try-runtime,experimental
     - cat /cargo_target_dir/debug/.fingerprint/memory_units-759eddf317490d2b/lib-memory_units.json || true
 
 # This job runs all benchmarks defined in the `/bin/node/runtime` once to check that there are no errors.
diff --git a/substrate/frame/support/test/tests/construct_runtime_ui.rs b/substrate/frame/support/test/tests/construct_runtime_ui.rs
index ec6758f4b295..c3197c99a72b 100644
--- a/substrate/frame/support/test/tests/construct_runtime_ui.rs
+++ b/substrate/frame/support/test/tests/construct_runtime_ui.rs
@@ -27,6 +27,9 @@ fn ui() {
 	// As trybuild is using `cargo check`, we don't need the real WASM binaries.
 	std::env::set_var("SKIP_WASM_BUILD", "1");
 
+	// Deny all warnings since we emit warnings as part of a Runtime's UI.
+	std::env::set_var("RUSTFLAGS", "--deny warnings");
+
 	let t = trybuild::TestCases::new();
 	t.compile_fail("tests/construct_runtime_ui/*.rs");
 }
diff --git a/substrate/frame/support/test/tests/pallet_ui/genesis_default_not_satisfied.rs b/substrate/frame/support/test/tests/pallet_ui/genesis_default_not_satisfied.rs
deleted file mode 100644
index a4a0eb832c9c..000000000000
--- a/substrate/frame/support/test/tests/pallet_ui/genesis_default_not_satisfied.rs
+++ /dev/null
@@ -1,26 +0,0 @@
-#[frame_support::pallet]
-mod pallet {
-	use frame_support::pallet_prelude::{BuildGenesisConfig, Hooks};
-	use frame_system::pallet_prelude::BlockNumberFor;
-
-	#[pallet::config]
-	pub trait Config: frame_system::Config {}
-
-	#[pallet::pallet]
-	pub struct Pallet<T>(core::marker::PhantomData<T>);
-
-	#[pallet::hooks]
-	impl<T: Config> Hooks<BlockNumberFor<T>> for Pallet<T> {}
-
-	#[pallet::call]
-	impl<T: Config> Pallet<T> {}
-
-	#[pallet::genesis_config]
-	pub struct GenesisConfig;
-
-	#[pallet::genesis_build]
-	impl BuildGenesisConfig for GenesisConfig {}
-}
-
-fn main() {
-}
diff --git a/substrate/frame/support/test/tests/pallet_ui/genesis_default_not_satisfied.stderr b/substrate/frame/support/test/tests/pallet_ui/genesis_default_not_satisfied.stderr
deleted file mode 100644
index 67cbe80be0da..000000000000
--- a/substrate/frame/support/test/tests/pallet_ui/genesis_default_not_satisfied.stderr
+++ /dev/null
@@ -1,16 +0,0 @@
-error[E0277]: the trait bound `pallet::GenesisConfig: std::default::Default` is not satisfied
-  --> tests/pallet_ui/genesis_default_not_satisfied.rs:22:30
-   |
-22 |     impl BuildGenesisConfig for GenesisConfig {}
-   |                                 ^^^^^^^^^^^^^ the trait `std::default::Default` is not implemented for `pallet::GenesisConfig`
-   |
-note: required by a bound in `BuildGenesisConfig`
-  --> $WORKSPACE/substrate/frame/support/src/traits/hooks.rs
-   |
-   | pub trait BuildGenesisConfig: Default + sp_runtime::traits::MaybeSerializeDeserialize {
-   |                               ^^^^^^^ required by this bound in `BuildGenesisConfig`
-help: consider annotating `pallet::GenesisConfig` with `#[derive(Default)]`
-   |
-19  +     #[derive(Default)]
-20  |     pub struct GenesisConfig;
-    |