Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add backpressure to Notifications substreams allocation #506

Open
dmitry-markin opened this issue May 18, 2023 · 0 comments
Open

Add backpressure to Notifications substreams allocation #506

dmitry-markin opened this issue May 18, 2023 · 0 comments

Comments

@dmitry-markin
Copy link
Contributor

dmitry-markin commented May 18, 2023 •
edited
Loading

As discussed in https://github.com/paritytech/substrate/pull/13611/files#r1183381298, Notifications must not accept new substreams if protocol is unable to handle them. After paritytech/substrate#13611 is merged, there is going to be an unbounded channel from Notifications to ProtocolController. This should ultimately be replaced with a bounded channel with appropriate modifications in NotificationService and protocols (upcoming refactoring).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
Networking
Status: Backlog 🗒
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dmitry-markin @the-right-joyce