Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor pallet-xcm to use fungible traits #7225

Closed
5 tasks
bkontur opened this issue Jan 17, 2025 · 1 comment
Closed
5 tasks

Refactor pallet-xcm to use fungible traits #7225

bkontur opened this issue Jan 17, 2025 · 1 comment
Labels
T6-XCM This PR/Issue is related to XCM.

Comments

@bkontur
Copy link
Contributor

bkontur commented Jan 17, 2025

Part of: #226
Relates to: paritytech/substrate#12951

/// A lockable currency.
// TODO: We should really use a trait which can handle multiple currencies.
type Currency: LockableCurrency<Self::AccountId, Moment = BlockNumberFor<Self>>;

TODO/Open questions

  • Replace LockableCurrency with fungible and freeze traits
  • Fix xcm_executor::traits::Enact implementations that use T::Currency
  • Check if migration is needed
  • Add try_state impl that checks LockedFungibles correctness with type Currency state (is it even possible)?
  • If we want to support multiple currencies, should we address it here or as a separate issue afterward?
@bkontur bkontur added the T6-XCM This PR/Issue is related to XCM. label Jan 17, 2025
@acatangiu
Copy link
Contributor

Duplicate of #7226

@acatangiu acatangiu marked this as a duplicate of #7226 Jan 17, 2025
@acatangiu acatangiu closed this as not planned Won't fix, can't repro, duplicate, stale Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T6-XCM This PR/Issue is related to XCM.
Projects
Status: Done
Development

No branches or pull requests

2 participants