Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Break subsystem-util out into a separate crate and restore the subsystem test-helpers crate #1515

Closed
rphmeier opened this issue Jul 31, 2020 · 1 comment · Fixed by #1553
Closed

Break subsystem-util out into a separate crate and restore the subsystem test-helpers crate #1515

rphmeier opened this issue Jul 31, 2020 · 1 comment · Fixed by #1553
Assignees
@coriolinus
Labels
I8-refactor Code needs refactoring.
Milestone
White Flint

Comments

@rphmeier
Copy link
Contributor

The test-helpers feature of the subsystem crate doesn't actually work as expected.

cc @bkchr who raised this in chat.
@rphmeier rphmeier added the I8-refactor Code needs refactoring. label Jul 31, 2020
@rphmeier rphmeier added this to the White Flint milestone Jul 31, 2020
@ordian
Copy link
Member

ordian commented Jul 31, 2020 •
edited
Loading

I guess this is related to #1403 (comment)

EDIT: after reading the discussion, it seems to be a concern about feature leaking.

@coriolinus coriolinus mentioned this issue Aug 7, 2020
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@coriolinus coriolinus

Labels
I8-refactor Code needs refactoring.
Projects
None yet
Milestone
White Flint
Development

Successfully merging a pull request may close this issue.

break out subsystem-util and subsystem-test-helpers into individual crates paritytech/polkadot
3 participants
@ordian @coriolinus @rphmeier