Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Land XCM v0 onto master #1783

Closed
pepyakin opened this issue Oct 5, 2020 · 6 comments
Closed

Land XCM v0 onto master #1783

pepyakin opened this issue Oct 5, 2020 · 6 comments

Comments

@pepyakin
Copy link
Contributor

pepyakin commented Oct 5, 2020

In #1657 the initial prototype version of XCM was introduced. However, it was coded against the v0 parachains, which at the time of writing this was already eradicated.

Note that this issue doesn't require complete polishness of XCM. The goal of this issue is to land XCM on master adapting it to the parachains v1 code to ultimately achieving feature parity with the v0 version - i.e. launch rococo v1 with XCM and demonstrate the same functionality.

@h4x3rotab
Copy link

Do we need to wait for this to test the XCM handlers on a rococo-template parachain?

@shawntabrizi
Copy link
Member

Follow up maybe for another issue:

@shawntabrizi
Copy link
Member

shawntabrizi commented Oct 7, 2020

Follow up:

  • Bring in the Sibiling struct which is not yet used
#[derive(Clone, Copy, Default, Encode, Decode, Eq, PartialEq, Ord, PartialOrd, RuntimeDebug)]
pub struct Sibling(pub Id);

impl From<Id> for Sibling {
	fn from(i: Id) -> Self {
		Self(i)
	}
}
impl From<Sibling> for Id {
	fn from(i: Sibling) -> Self {
		i.0
	}
}
impl AsRef<Id> for Sibling {
	fn as_ref(&self) -> &Id {
		&self.0
	}
}
impl TypeId for Sibling {
	const TYPE_ID: [u8; 4] = *b"sibl";
}
impl From<Sibling> for u32 {
	fn from(x: Sibling) -> Self { x.0.into() }
}

impl From<u32> for Sibling {
	fn from(x: u32) -> Self { Sibling(x.into()) }
}

impl IsSystem for Sibling {
	fn is_system(&self) -> bool {
		IsSystem::is_system(&self.0)
	}
}

@rphmeier

This comment has been minimized.

@pepyakin pepyakin modified the milestones: Medical Center, Bethesda Nov 19, 2020
@pepyakin

This comment has been minimized.

@pepyakin
Copy link
Contributor Author

pepyakin commented Jul 7, 2021

I think this issue is not longer relevant as all parts were landed.

@pepyakin pepyakin closed this as completed Jul 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants