Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Statement distribution likely does not connect properly to the validator peer set. #2400

Closed
eskimor opened this issue Feb 8, 2021 · 5 comments
Assignees
Labels
I3-bug Fails to follow expected behavior.

Comments

@eskimor
Copy link
Member

eskimor commented Feb 8, 2021

See discussion here

@eskimor eskimor added the U1-asap No need to stop dead in your tracks, however issue should be addressed as soon as possible. label Feb 8, 2021
@eskimor
Copy link
Member Author

eskimor commented Feb 9, 2021

Ok, it will take me a bit longer to look into this. If anyone wants to pick this up sooner - be my guest :-) It is not super critical as connections seem to work since #2372 .

@ordian ordian added I3-bug Fails to follow expected behavior. and removed U1-asap No need to stop dead in your tracks, however issue should be addressed as soon as possible. labels Feb 9, 2021
@ordian ordian added this to the Friendship Heights milestone Feb 9, 2021
@rphmeier
Copy link
Contributor

Statement distribution doesn't need to connect to the validator set as it's meant to be a gossip protocol where all validators see all statements. The statements themselves are light in the case of code upgrades. although we should optimize this later on.

The reason all validators need to see all statements is because the block author needs to include backed candidates from all parachains, not just its own group. And in BABE or SASSAFRAS (future), the block author isn't known to other nodes.

@rphmeier
Copy link
Contributor

What this "bughunting" issue is really about is ensuring that statements are propagating correctly among all nodes.

@eskimor
Copy link
Member Author

eskimor commented Feb 24, 2021

In particular it should be checked that connections on the validation peer set are actually opened before messages are being sent to a particular peer.

@eskimor
Copy link
Member Author

eskimor commented Feb 26, 2021

Closing, as obsoleted by #2536 .

@eskimor eskimor closed this as completed Feb 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
I3-bug Fails to follow expected behavior.
Projects
None yet
Development

No branches or pull requests

3 participants