Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

CI: add clippy checks #6332

Closed
3 tasks
ordian opened this issue Nov 22, 2022 · 3 comments · Fixed by #6341
Closed
3 tasks

CI: add clippy checks #6332

ordian opened this issue Nov 22, 2022 · 3 comments · Fixed by #6341

Comments

@ordian
Copy link
Member

ordian commented Nov 22, 2022

Steps:

@ordian ordian added the Q2-easy label Nov 22, 2022
@ghost ghost self-assigned this Nov 22, 2022
@bkchr
Copy link
Member

bkchr commented Nov 22, 2022

It should be exactly the same config. We should not use different confings in our repos.

@ordian
Copy link
Member Author

ordian commented Nov 23, 2022

It should be exactly the same config. We should not use different confings in our repos.

We could initially allow more lints to fail and fix them gradually.
There are also some lints in Substrate that could be fixed in Polkadot (I haven't actually checked, but in theory), e.g.

"-Aclippy::borrowed-box", # Reasonable to fix this one

We shouldn't wait for substrate to fix it first.

@bkchr
Copy link
Member

bkchr commented Nov 23, 2022

I just want the same behavior across repos. Especially as a lot of clippy settings are very opinionated stuff or force you to do stuff in way that is more correct in theory, but doesn't change anything in practice.

@ordian ordian linked a pull request Nov 25, 2022 that will close this issue
@ghost ghost closed this as completed in #6341 Nov 30, 2022
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants