Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Upgrade libp2p primitives to use tokio implementations #12499

Closed
2 tasks
dmitry-markin opened this issue Oct 15, 2022 · 0 comments · Fixed by #12646
Closed
2 tasks

Upgrade libp2p primitives to use tokio implementations #12499

dmitry-markin opened this issue Oct 15, 2022 · 0 comments · Fixed by #12646
Assignees
@dmitry-markin

Comments

@dmitry-markin
Copy link
Contributor

dmitry-markin commented Oct 15, 2022 •
edited
Loading

Description

Transports and protocols in libp2p currently have different implementations for tokio and async-std runtimes (see libp2p/rust-libp2p#2962). Due to historical reasons, transports and protocols used in substrate rely on async-std primitives, which can cause issues under tokio runtime like this one: libp2p/rust-libp2p#2748. They should be upgraded to use tokio implementations.

This requires changing primitives used (i.e., replacing TcpTransport with TokioTcpTransport) and upgrading tokio version to the one compatible with libp2p.

This is a follow-up issue to #12256.

Checklist

  • Upgrade tokio to the latest version.
  • Replace async-std libp2p primitives used by their tokio variants.
@dmitry-markin dmitry-markin mentioned this issue Oct 15, 2022
Merged
@dmitry-markin dmitry-markin moved this to Backlog 🗒 in SDK Node Oct 17, 2022
@dmitry-markin dmitry-markin self-assigned this Nov 3, 2022
@dmitry-markin dmitry-markin mentioned this issue Nov 8, 2022
Merged
Repository owner moved this from Backlog 🗒 to Done ✅ in SDK Node Dec 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@dmitry-markin dmitry-markin

Labels
None yet
Projects
SDK Node
Status: done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Upgrade tokio to 1.22.0 and replace async-std with tokio paritytech/substrate
1 participant
@dmitry-markin