You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
The current try-runtime code paths are all using a very very rudimentary &'static str as the error type. Even worse, we don't really handle the error in many places because these strings are not all that useful.
Instead, the try-runtime APIs and machinery should either have its very own error type, or even better, use the very flexible DispatchError. All existing &'static str error can be easily converted to DispatchResult via .into().
This is slightly bad in terms of naming, as try-runtime code paths are not necessarily Dispatched, but we really want to reuse DispatchResult's ability to reference exactly which module it is coming from.
If someone works on this and realizes that it is not worthwhile, or if there is a technical issue along the way, we should remove the return type and simply standardize panics in try_state and family.
The text was updated successfully, but these errors were encountered:
The current try-runtime code paths are all using a very very rudimentary
&'static str
as the error type. Even worse, we don't really handle the error in many places because these strings are not all that useful.Instead, the try-runtime APIs and machinery should either have its very own error type, or even better, use the very flexible
DispatchError
. All existing&'static str
error can be easily converted toDispatchResult
via.into()
.This is slightly bad in terms of naming, as
try-runtime
code paths are not necessarilyDispatched
, but we really want to reuseDispatchResult
's ability to reference exactly which module it is coming from.If someone works on this and realizes that it is not worthwhile, or if there is a technical issue along the way, we should remove the return type and simply standardize panics in
try_state
and family.The text was updated successfully, but these errors were encountered: