Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Use proper weights in the pallet-template #13761

Closed
ggwpez opened this issue Mar 29, 2023 · 0 comments · Fixed by #13817
Closed

Use proper weights in the pallet-template #13761

ggwpez opened this issue Mar 29, 2023 · 0 comments · Fixed by #13817
Labels
Z1-easy Can be fixed primarily by duplicating and adapting code by an intermediate coder Z6-mentor An easy task where a mentor is available. Please indicate in the issue who the mentor could be.

Comments

@ggwpez
Copy link
Member

ggwpez commented Mar 29, 2023 •
edited
Loading

substrate/bin/node-template/pallets/template/src/lib.rs

Line 67 in 1bbde5d

#[pallet::weight(10_000 + T::DbWeight::get().writes(1).ref_time())]

Either we should use proper benchmarking or put that pallet in dev-mode. Like this it is an anti-example of how to not do it 🙈
@ggwpez ggwpez added Z6-mentor An easy task where a mentor is available. Please indicate in the issue who the mentor could be. Z1-easy Can be fixed primarily by duplicating and adapting code by an intermediate coder labels Mar 29, 2023
@ggwpez ggwpez mentioned this issue Apr 3, 2023
Open
@AlexD10S AlexD10S mentioned this issue Apr 4, 2023
Merged
@AlexD10S AlexD10S linked a pull request Apr 5, 2023 that will close this issue
Use proper weights in the pallet-template #13817
Merged
@github-project-automation github-project-automation bot moved this from Backlog to Done in Benchmarking and Weights Apr 6, 2023
@github-project-automation github-project-automation bot moved this from Backlog to Done in Runtime / FRAME Apr 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Z1-easy Can be fixed primarily by duplicating and adapting code by an intermediate coder Z6-mentor An easy task where a mentor is available. Please indicate in the issue who the mentor could be.
Projects
Benchmarking and Weights
Status: Done
Runtime / FRAME
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use proper weights in the pallet-template paritytech/substrate
1 participant
@ggwpez