Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Remove clear_on_drop dependency #6677

Closed
tomaka opened this issue Jul 17, 2020 · 2 comments · Fixed by #6710
Closed

Remove clear_on_drop dependency #6677

tomaka opened this issue Jul 17, 2020 · 2 comments · Fixed by #6710
Labels
Z1-easy Can be fixed primarily by duplicating and adapting code by an intermediate coder

Comments

@tomaka
Copy link
Contributor

tomaka commented Jul 17, 2020 •
edited
Loading

After #6676, we no longer need the clear_on_drop dependency in the browser node.
@tomaka tomaka added the Z1-easy Can be fixed primarily by duplicating and adapting code by an intermediate coder label Jul 17, 2020
@tomaka tomaka mentioned this issue Jul 22, 2020
Merged
@xlc
Copy link
Contributor

xlc commented Jul 22, 2020

So the root cause of #4179 is fixed?

@tomaka
Copy link
Contributor Author

tomaka commented Jul 23, 2020

Before #6676, clear_on_drop was a dependency of ed25519-dalek. The root cause of #4179 is that compiling the runtime isn't supposed to compile ed25519-dalek (and thus not clear_on_drop either).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Z1-easy Can be fixed primarily by duplicating and adapting code by an intermediate coder
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove clear_on_drop from browser util crate tomaka/polkadot
2 participants
@xlc @tomaka