Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

SelectChain::finality_target should not return an Option #9177

Closed
andresilva opened this issue Jun 22, 2021 · 1 comment · Fixed by #9867
Closed

SelectChain::finality_target should not return an Option #9177

andresilva opened this issue Jun 22, 2021 · 1 comment · Fixed by #9867
Labels
J0-enhancement An additional feature request. Z1-easy Can be fixed primarily by duplicating and adapting code by an intermediate coder

Comments

@andresilva
Copy link
Contributor

In absence of a better finality target any select chain implementation can just return the target hash it was called with.
@andresilva andresilva added J0-enhancement An additional feature request. Z1-easy Can be fixed primarily by duplicating and adapting code by an intermediate coder labels Jun 22, 2021
@tau3 tau3 mentioned this issue Jun 24, 2021
Closed
@gilescope gilescope mentioned this issue Jul 6, 2021
Closed
@gilescope gilescope self-assigned this Jul 6, 2021
@gilescope
Copy link
Contributor

I'm all for simplifiying things.

@gilescope gilescope removed their assignment Jul 7, 2021
@liuchengxu liuchengxu mentioned this issue Sep 26, 2021
Merged
@ghost ghost closed this as completed in #9867 Sep 29, 2021
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
J0-enhancement An additional feature request. Z1-easy Can be fixed primarily by duplicating and adapting code by an intermediate coder
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Return target_hash for finality_target instead of an Option liuchengxu/substrate
2 participants
@andresilva @gilescope