Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changed incorrect key name in apple auth adapter tests #6861

Merged

Conversation

mtrezza
Copy link
Member

@mtrezza mtrezza commented Aug 15, 2020

It seems that refactoring in 8e0e485 did not cover all parameters in apple auth adapter testing.

This PR should not have any functional impact.

closes #6858

@mtrezza mtrezza requested a review from dplewis August 15, 2020 12:05
@dplewis
Copy link
Member

dplewis commented Aug 25, 2020

@mtrezza Can you rebase from master to fix the tests? We should also update the changelog / release log with the refactoring. Should we add support for both client_id / clientId for backwards compatibility or can we ignore it?

@mtrezza
Copy link
Member Author

mtrezza commented Aug 25, 2020

Can you rebase from master to fix the tests?

done

We should also update the changelog / release log with the refactoring.

The change has been merged here on March 11 and released as Parse Server 4.2.0. I've retroactively added an entry to the change log for release 4.2.0.

Should we add support for both client_id / clientId for backwards compatibility or can we ignore it?

I don't think so. The change has been half a year ago, and even back then I would not have gone for backwards compatibility for something that only requires to change a key in the Parse Server config.

Copy link
Member

@dplewis dplewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mtrezza mtrezza merged commit 9831215 into parse-community:master Aug 25, 2020
@mtrezza mtrezza deleted the unify-key-name-in-apple-auth-adapter branch March 27, 2022 00:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Apple sign in client_id typo
3 participants