fix: pin root CA instead of intermediate CA in thanos-tls-querier #2892
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
malvex
requested review from
ArchiFleKs and
rguichard
and removed request for
a team
ArchiFleKs
approved these changes
Aug 5, 2024
|
🎉 This PR is included in version 16.5.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces intermediate CA cert (R3) with root CA cert (X1).
In thanos-tls-querier, an intermediate CA cert (R3) was pinned. However, when cert-manager requested a new certificate issued by a higher-level CA (R11), it caused an error
transport: authentication handshake failed: x509: certificate signed by unknown authority.In general, intermediate certificates shouldn't be pinned; instead, root certificates should be pinned (e.g., LetsEncrypt X1 root CA). This ensures that the trust chain is maintained when certificates are updated or replaced.