-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create Resource is completly bugged #32
Comments
With how the UI behaves this seems like the resource_type_id is missing from the create request but in the debug log it is clearly there, even in the servers response. I will look at this in the Evening when i have some time. |
Hi, could you run some Tests for me?
Please also Attach the CLI debug logs for the Get and Update. |
@speatzle sure!
It looks like creating the resource via UI eliminates the problem, so far it only occures in my tests when the resource got initially created over the CLI. |
Ok, if you create a new Password with a Description via the CLI instead of adding it with an update, does the same issue occur? |
I believe I have found the issue. When go-passbolt (the library behind go-passbolt-cli) creates a new resource it tries to create it with the Since I don't have a Server with this behavior I can't test the fix, would you be willing to compile and test the fix on your system? Alternatively, I could also compile and upload a binary. |
If you could compile it and share the binary, I'd be happy to test it out. Its probably be quicker that way |
Here is the test Version. |
I could upgrade my system but maybe we'll destroying the test-case then. Could you offer a static version or a version with lower glib? |
I recompiled without glib by disabling cgo. Hope that works. |
That indeed helped and fixed the problem!
Thank you. I tested create and update, looks very good so far |
Perfect, ill make a new go-passbolt and go-passbolt-cli release soon, Thank you for the Report and help. |
Released with v0.3.0 |
Describe the bug:
When creating a new ressource, using:
passbolt create resource --name "delme4" --username "hi" --uri "wow.de" --password="1"
the created resource then has a JSON entry with the password itself in the password field:
? It goes even further, when updating the value then with:
passbolt update resource --id 940be140-6981-4d5a-bb7b-9cb64fe5bf7d -p "123"
This seems to work, but only until I try to pull the ressource 'delme4' with the ansible lookup plugin, which will throw an JSON Error when the resource got created over the
go-passbolt-cli
:Maybe something in my Setup is wrong? Everything else works as excepted (pulling/listening resources for example)
When adding a description:
To Reproduce:
Just run
passbolt create resource --name "delme4" --username "hi" --uri "wow.de" --password="1"
Output when using --debug (you should censor this):
Passbolt Server Version (please complete the following information):
go-passbolt-cli Version (please complete the following information):
The text was updated successfully, but these errors were encountered: