forked from jonstorer/passport-mocked
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert tests from mocha to jest #2
Labels
enhancement
New feature or request
Comments
Fine with me, gives me a new framework to learn 👍 |
When this gets done we could do with test coverage being added so coveralls works. |
@rwky - That comes with Jest. |
@guyellis just wondering how you're getting on with this? |
@rwky - sorry - slammed at the moment. Not sure when I'll get to look at this. |
No worries it's not critical! |
@guyellis That would be great |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
@rwky how do you feel about me converting the tests for this repo from
mocha
tojest
?The reason that I like
jest
in this context is because it has "all the things."One of the patterns that I want to fix in this repo is having mocked code in the target prod code. To get away from that we need to inject this mock from the test into the target code. To do this with mocha we need to either hand-roll it or add another dependency like
sinon
taking out dev dependencies up to 3. With jest we can drop our dev dependencies for testing down to 1.(Separately we still need to increase the number of dev dependencies for thing like linting but that's another matter.)
The text was updated successfully, but these errors were encountered: