Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert tests from mocha to jest #2

Open
guyellis opened this issue Aug 8, 2018 · 7 comments
Open

Convert tests from mocha to jest #2

guyellis opened this issue Aug 8, 2018 · 7 comments
Assignees
Labels
enhancement New feature or request

Comments

@guyellis
Copy link

guyellis commented Aug 8, 2018

@rwky how do you feel about me converting the tests for this repo from mocha to jest?

The reason that I like jest in this context is because it has "all the things."

One of the patterns that I want to fix in this repo is having mocked code in the target prod code. To get away from that we need to inject this mock from the test into the target code. To do this with mocha we need to either hand-roll it or add another dependency like sinon taking out dev dependencies up to 3. With jest we can drop our dev dependencies for testing down to 1.

(Separately we still need to increase the number of dev dependencies for thing like linting but that's another matter.)

@guyellis guyellis added the enhancement New feature or request label Aug 8, 2018
@guyellis guyellis self-assigned this Aug 8, 2018
@rwky
Copy link

rwky commented Aug 8, 2018

Fine with me, gives me a new framework to learn 👍

@rwky
Copy link

rwky commented Aug 11, 2018

When this gets done we could do with test coverage being added so coveralls works.

@guyellis
Copy link
Author

@rwky - That comes with Jest.

@rwky
Copy link

rwky commented Jan 22, 2019

@guyellis just wondering how you're getting on with this?

@guyellis
Copy link
Author

@rwky - sorry - slammed at the moment. Not sure when I'll get to look at this.

@rwky
Copy link

rwky commented Jan 24, 2019

No worries it's not critical!

@drayzii
Copy link

drayzii commented Oct 10, 2019

@guyellis That would be great

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants