Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mishti: change EAS & Verax attestation schema #3189

Open
nutrina opened this issue Jan 21, 2025 · 0 comments · May be fixed by #3317 or passportxyz/passport-scorer#785
Open

Mishti: change EAS & Verax attestation schema #3189

nutrina opened this issue Jan 21, 2025 · 0 comments · May be fixed by #3317 or passportxyz/passport-scorer#785
Assignees

Comments

@nutrina
Copy link
Collaborator

nutrina commented Jan 21, 2025

This request affects the following components:

  • iam (for creating new payloads)
  • eas-proxy (both EAS & Verax)

Depends on: #3187

Summary

  • we will drop the current EAS schemas in favour of using only 1 attestation that will have the same structure as the score in the new V2 API, with some adjustments:
    • new field will be added score_id
  • we will need to update the iam package to create the proper payloads
  • the functionality should be off by default and enabled by the same feature flag as the one in Mishti: implement double hashing (iam, embed, infra) #3187
  • the contracts in eas-proxy need to be adjusted:
    • we want the functions in the https://github.com/passportxyz/eas-proxy/blob/main/contracts/IGitcoinPassportDecoder.sol to remain backwards compatible with the old schemas as much as possible
      • the only exception will be the getPassport function which returns an array of Credential) for which we will only populate the provider field from now on
    • we might add other functions we consider important (like getStamps(), getStamps(scorer_id) , getFullScore(scorer_id)... these are just a few ideas at the moment)
  • make adjustments for the Verax smart contracts & portal

Acceptance criteria

GIVEN I have a verified my stamps in the Passport app
WHEN I click the "Bring Passport onchain" button
THEN my current score is written to the blockchain as a EAS attestation
AND I can view the score, and related metadata (providers, weights, deduplication information) in the eAS explorer

GIVEN I have written my score on-chain
WHEN I refresh the passport application
AND I click on the "Mint onchain" button
THEN sidebar opens and the the onchain status displays that my on-chain score is up to date correctly displayed

GIVEN I have written my score on-chain
WHEN I refresh the passport application
AND I claim one more stamp and increase my score
AND I click on the "Mint onchain" button
THEN sidebar opens and the the onchain status is correctly displayed and indicates that my on-chain score is not up to date

@nutrina nutrina converted this from a draft issue Jan 21, 2025
@Jkd-eth Jkd-eth changed the title Mishti: change EAS attestation schema Mishti: change EAS & Verax attestation schema Jan 21, 2025
@lucianHymer lucianHymer moved this from Prioritized to In Progress (WIP) in Passport New Feb 14, 2025
@lucianHymer lucianHymer self-assigned this Feb 14, 2025
@lucianHymer lucianHymer moved this from In Progress (WIP) to Prioritized in Passport New Feb 17, 2025
@lucianHymer lucianHymer removed their assignment Feb 19, 2025
@lucianHymer lucianHymer moved this from Prioritized to In Progress (WIP) in Passport New Feb 26, 2025
@lucianHymer lucianHymer moved this from In Progress (WIP) to Prioritized in Passport New Feb 26, 2025
@lucianHymer lucianHymer moved this from Prioritized to In Progress (WIP) in Passport New Feb 27, 2025
@lucianHymer lucianHymer self-assigned this Feb 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Progress (WIP)
2 participants