Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why i cant register header as class? only via xib(( from @Majid #75

Closed
patchthecode opened this issue Jul 15, 2016 · 12 comments
Closed

Comments

@patchthecode
Copy link
Owner

Why i cant register header as class? only via xib((

@patchthecode
Copy link
Owner Author

There are two functions that you can use. Choose anyone that you like.

  1. calendarView.registerCellViewClass(fileName: "myFileName")
  2. calendarView.registerCellViewClass(cellClass: class.type)

@patchthecode patchthecode self-assigned this Jul 15, 2016
@mecid
Copy link

mecid commented Jul 15, 2016

This is only for day cells? Or i can use it for Month Header too?

@patchthecode
Copy link
Owner Author

patchthecode commented Jul 15, 2016

oooooh. O_o
Damn.. I did not need this in my project, so i didnt think about it 😁

I will have an update for you over the weekend.
Sounds good?

@patchthecode
Copy link
Owner Author

patchthecode commented Jul 15, 2016

By the way, I mainly use xibs in my projects. I do not use classes, so the testing in that area is not as much as what i did for the xibs. If you find anything wrong in that area, literally anything wrong (even the smallest thing), then let me know. This library should have no bugs.

I am interested to see how your calendar turns out. The sample picture you provided was very interesting.

@mecid
Copy link

mecid commented Jul 15, 2016

I am using simple Month Header with single label and don't want to use xibs.
simulator screen shot 15 2016 4 31 26

@patchthecode
Copy link
Owner Author

patchthecode commented Jul 15, 2016

Looks great. I can't wait to see it when it is finished.

By the way. Look at this:
screen shot 2016-07-15 at 11 08 30 am

Is this a bug?
Maybe I am seeing it wrong, but does the bottom look more flat than the top to you?

@patchthecode
Copy link
Owner Author

patchthecode commented Jul 16, 2016

Hey, I have pushed your enhancement to the master repository. Can you test it?
If you are using CocoaPods, then follow the instructions on *question 6 * here to test master branch -> https://github.com/patchthecode/JTAppleCalendar/wiki/Common-Questions

Let me know how it goes. If you have no bugs or issues, I will release the next 4.1.3 version with this update.

@mecid
Copy link

mecid commented Jul 17, 2016

@patchthecode I am using master branch and all working good! Thanks.

@patchthecode
Copy link
Owner Author

great. closing this.

@mecid
Copy link

mecid commented Jul 17, 2016

Do you release it?

@patchthecode
Copy link
Owner Author

Not yet.
I have to do some more rounds of testing. But I will release it over this weekend.
For now, you are the test subject :)

@mecid
Copy link

mecid commented Jul 18, 2016

@patchthecode ok, no problem))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants