Skip to content

Commit

Permalink
Clarify (dotnet#4596)
Browse files Browse the repository at this point in the history
  • Loading branch information
gewarren authored and patilb committed May 31, 2021
1 parent be1295d commit a1a9ae3
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 23 deletions.
13 changes: 2 additions & 11 deletions .github/actions/status-checker/dist/index.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion .github/actions/status-checker/dist/index.js.map

Large diffs are not rendered by default.

12 changes: 1 addition & 11 deletions .github/actions/status-checker/src/status-checker.ts
Original file line number Diff line number Diff line change
Expand Up @@ -96,17 +96,7 @@ export async function checkStatus(token: string) {

if (buildStatus.state == 'success') {
if (buildStatus.description == 'Validation status: warnings') {
console.log('Found build warnings.');
core.setFailed('Please fix build warnings before merging.');

// return await octokit.repos.createCommitStatus({
// owner: owner,
// repo: repo,
// sha: commit,
// state: 'failure',
// context: 'Check for build warnings',
// description: 'Please fix build warnings before merging.',
// })
core.setFailed("Please fix OPS build warnings before merging. To see the warnings, click 'Details' next to the OpenPublishing.build status check at the bottom of your pull request.");
}
else {
console.log("OpenPublishing.Build status check does not have warnings.");
Expand Down

0 comments on commit a1a9ae3

Please sign in to comment.