Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The Prettier plugin doesn't see the Prettier package installed and symlinked by PNPM #7

Open
rafaucau opened this issue May 7, 2024 · 3 comments

Comments

@rafaucau
Copy link

rafaucau commented May 7, 2024

Description

While PHPStorm supports symlinks with this plugin, the Prettier plugin from Jetbrains does not.

intelij-prettier
image

Steps to Reproduce

  1. Install Prettier plugin: https://plugins.jetbrains.com/plugin/10456-prettier
  2. Use PNPM to install Prettier in project: pnpm install prettier
  3. Try to configure Prettier plugin in the IDE

Versions

The first two lines of the Help -> About output:

  • PhpStorm 2024.1.1
  • Build #PS-241.15989.102, built on April 23, 2024

The version of wsl-symlinks (Settings -> Plugins -> Wsl Symlinks):

  • 2024.1.5
@rafaucau
Copy link
Author

rafaucau commented May 7, 2024

And the same issue with ESLint:
image

@patricklx
Copy link
Owner

I looked into this. But it looks like there is nothing i can do here.
It uses nio file system path directly. It's possible to set a custom default file system. But its loaded at app start, so before this plugin is loaded... Then it cannot load the custom file system and fails

@haosmos
Copy link

haosmos commented May 18, 2024

I looked into this. But it looks like there is nothing i can do here. It uses nio file system path directly. It's possible to set a custom default file system. But its loaded at app start, so before this plugin is loaded... Then it cannot load the custom file system and fails

I also faced this problem. However, I note that the tools themselves (eslint, prettier) work – ide sees these packages inside wsl and they can be used.

You say that the plugin is loaded after the ide is launched, but what if you make it so that after the ide starts, the plugin will show a notification, something like: “For the wsl symlink plugin to work correctly, please reload the ide.”

I think that if this is the only option, then it would be a reasonable compromise. I don't think the ide reboot, which takes about 10 seconds, is a problem. This wouldn't be a problem for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants