Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

morphablemodel::get_mean() for models with expressions #188

Closed
patrikhuber opened this issue Apr 1, 2018 · 1 comment
Closed

morphablemodel::get_mean() for models with expressions #188

patrikhuber opened this issue Apr 1, 2018 · 1 comment

Comments

@patrikhuber
Copy link
Owner

For MorphableModels that contain a PCA expression model, we have to decide whether morphablemodel::get_mean() should return the combined identity + expression mean. If yes, that would mean that the result probably wouldn't be a neutral face.

@patrikhuber
Copy link
Owner Author

Changed this in b8be436 to return the overall, combined mean now. I think that's the more sound way.
If someone wants the obtain the neutral-only shape mean, they can use get_shape_model().get_mean() and sample_to_mesh.

@patrikhuber patrikhuber removed the devel-branch Issues affecting only the devel branch. label May 13, 2018
Repository owner deleted a comment from sunjunlishi Jul 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant