Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate Style Modifiers #1177

Closed
bmuenzenmeyer opened this issue May 1, 2020 · 3 comments · Fixed by #1452
Closed

Deprecate Style Modifiers #1177

bmuenzenmeyer opened this issue May 1, 2020 · 3 comments · Fixed by #1452
Labels
breaking ❗ Use this labe if the change will break the current pattern lab behavior core pinned 📌 Don't let stalebot clean this up

Comments

@bmuenzenmeyer
Copy link
Member

Converted from https://github.com/orgs/pattern-lab/projects/3

http://patternlab.io/docs/pattern-stylemodifier.html

BM: Template Engines accomplish this in their own way. Kill this mustachism

@JosefBredereck
Copy link
Contributor

What exactly are style modifiers? I know the pattern parameters but forgot the other since the docs are not available anymore.

@mfranzke
Copy link
Contributor

What exactly are style modifiers? I know the pattern parameters but forgot the other since the docs are not available anymore.

Here‘s their previous specs content:
https://web.archive.org/web/20180710175641/http://patternlab.io/docs/pattern-stylemodifier.html

I‘ll try to find more details/issue regarding their deprecation.

@bmuenzenmeyer
Copy link
Member Author

We wanted to deprecate them because it was another place where PL created a proprietary mustache extension that locked pattern content into PL but not the broader community. You couldn't migrate your PL patterns into 11ty or some such thing that understood mustache.

This desire to get back to vanilla support for template languages drove a lot of decisions.

@mfranzke mfranzke linked a pull request Dec 24, 2022 that will close this issue
@mfranzke mfranzke added the breaking ❗ Use this labe if the change will break the current pattern lab behavior label Dec 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking ❗ Use this labe if the change will break the current pattern lab behavior core pinned 📌 Don't let stalebot clean this up
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants