Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Watching pattern updates seems to get locked #439

Closed
mbulfair opened this issue Aug 17, 2016 · 4 comments
Closed

Watching pattern updates seems to get locked #439

mbulfair opened this issue Aug 17, 2016 · 4 comments

Comments

@mbulfair
Copy link

I am using Pattern Lab Node v2.4.2 on Windows, with Node v4.4.7, using the Gulp Edition.

Expected Behavior

Change to a mustache file happens, hit save, patterns runs the build task, then reload page.

Actual Behavior

Change happens, it builds, then reloads, and builds a second time. On occasion when "cleanPublic" is set to true in the config, this step will fail with unable to write to the public/patterns/ folder.

In the screenshot, first arrow is when a change was triggered, the second arrow is where it starts to hang up.
0unjwul

Steps to Reproduce

gulp patternlab:serve
Make a change to a pattern
Observe console

@bmuenzenmeyer
Copy link
Member

possibly related

image

@bmuenzenmeyer
Copy link
Member

@mbulfair can you try switching your patternlab-node entry in the dependencies object of your package.json to pattern-lab/patternlab-node#dev and run npm update to see if this issue is resolved?

@mbulfair
Copy link
Author

This bug seems to be resolved. I managed to make several mustache changes, it reloaded after the build, the navigation bar didn't duplicate, nor did I see a error for a nonemptydir for patterns.

@bmuenzenmeyer
Copy link
Member

yay - good to hear!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants