Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Engines need to able to decide how output files' code is formatted and add files #541

Closed
geoffp opened this issue Oct 23, 2016 · 0 comments

Comments

@geoffp
Copy link
Contributor

geoffp commented Oct 23, 2016

During development of the React engine, which is necessarily much more complex than other engines, it was discovered that the default output formatter (which is tuned to indent HTML output only) was destructive to the display of React components, which are JSX, causing them all to appear on one line. Likewise, because React components are required to be mounted to a container element, which must be present in the rendered output, yet we would still like to display the HTML output on its own, engine formatters should be able to post-process markup however they wish.

Therefore, we need a way to provide hooks for engines to be able to do their own code formatting for each type of output file, and probably also add their own files to the output.

@geoffp geoffp self-assigned this Oct 23, 2016
@geoffp geoffp changed the title Engines need to able to decide how code is formatted and output additional files Engines need to able to decide how output files' code is formatted and add files Oct 23, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants