Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug - Table - hoverable example invalid markup and selection not announced on navigation #7745

Open
thatblindgeye opened this issue Jul 25, 2022 · 1 comment
Labels

Comments

@thatblindgeye
Copy link
Contributor

thatblindgeye commented Jul 25, 2022

Describe the problem
Followup to #7732

The hoverable selectable Table example throws the following warning in the dev environment:

Warning: validateDOMNesting(...): <output> cannot appear as a child of <tbody>

Additionally, due to the way screen readers navigate tables (by cell rather than by row), the row that is selected only gets announced when a row is selected via a cell. Using Tab to navigate between rows (as the table caption instructs) does announce whether the row is selected, but it only announces the aria-label and not the content of the row.

Some possible alternatives:

  • Add a hidden input to each row, similar to the implementation seen in Data list selectable rows example. To avoid invalid markup, I believe this might require having an empty column similar to the table examples that use visible radio inputs.
  • Add a hidden input to the first cell of a row, and add styling so that when the radio input has focus it looks like the row has focus.
  • Move the current output element to the first <td> element of a row

How do you reproduce the problem?
Navigate the Hoverable selectable table example with a screen reader

Expected behavior
Markup is valid, and users can be notified whether the current row is selected as best as possible

Is this issue blocking you?
No

Screenshots
N/A

What is your environment?
N/A

What is your product and what release date are you targeting?
N/A

Any other information?
N/A

@mcarrano mcarrano added this to the 2022.13 milestone Aug 1, 2022
@nicolethoen nicolethoen moved this to Not started in PatternFly Issues Aug 16, 2022
@mcarrano mcarrano modified the milestones: 2022.13, 2022.14 Sep 2, 2022
@mcarrano mcarrano modified the milestones: 2022.14, 2023.02 Sep 23, 2022
@mcarrano mcarrano modified the milestones: 2023.02, 2022.16 Oct 26, 2022
@mcarrano mcarrano modified the milestones: 2022.16, 2023.01 Nov 11, 2022
@mcarrano mcarrano modified the milestones: 2023.01, Prioritized Backlog Nov 29, 2022
@nicolethoen nicolethoen removed the PF5 label Mar 7, 2023
@kmcfaul kmcfaul removed the bug label Oct 25, 2024
@tlabaj tlabaj removed this from the Prioritized Backlog milestone Nov 21, 2024
Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Not started
Development

No branches or pull requests

5 participants