[Discussion] vcpkg port

[Nemirtingas]

Hi,

Can we talk about vcpkg in this issue ?

I am trying to port your libs libjuice and libdatachannel to vcpkg. I have a working set of portfiles that I now use with vcpkg and I'm setting em up for a merge into the main vcpkg branch.
microsoft/vcpkg#13703
microsoft/vcpkg#13704

1st question: Can you add an option to build the tests in the libjuice CMake file ? BUILD_TESTS to enable/disable juice-tests ?

[paullouisageneau]

Sure, this PR adds the NO_TESTS (to be coherent with libdatachannel) parameter to libjuice: paullouisageneau/libjuice#37

[Nemirtingas]

libjuice looks nice with the:

Dependencies

None!

[paullouisageneau]

Yes indeed, that's pretty cool! Thanks for the suggestion.

I don't know if the pun was intended, since you can use libjuice instead of libnice 😆

[Nemirtingas]

And thats easier to port to vcpkg ;). Just waiting a new tag with the internal HMAC

[paullouisageneau]

OK, here it is: https://github.com/paullouisageneau/libjuice/releases/tag/v0.5.2

[Nemirtingas]

Oh, ok thanks. No hurry, the vcpkg team doesn't seem to look at my changes for now.
But I'll update my port :).

[Nemirtingas]

Hooray, libjuice is now supported in vcpkg.

[paullouisageneau]

Yay, great news! Thank you for handling this.

[Nemirtingas]

Guess this discussion is over now. libdatachannel and libjuice has been merged to vcpkg.
We just need to keep it up to date.

[paullouisageneau]

Congrats, thank you very much for this, I think it'll be useful to many people!